-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in highs api and status handling in both cases #682
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Guille. I like the mapping dictionary, because it's easy to read. Could it be kept while improving the precision that these changes bring?
I've added a status mapping dict with two codes but I still have to leave an exception to the dictionary for the |
can you please add a unit test that proves that there was something wrong and it was fixed? thanks |
…without solution. Test available for HiGHS and CBC for now
I think the new test should take into account the main issue that was solved that the solver as returning status 0 on time limit even if a solution was founded. The new test should be able to be extended to other solvers to check correct status handling on time limit without a solution. I will try to add (in a new PR soon) the ability for the checks, on the |
also, is this related to #624? |
As far as I can see point 2 of the ones mentioned on the PR should be on par with the changes done here to HiGHS. |
The status while solving with HiGHS was not getting updated properly and It would give back a wrong solution code on time limit but with a solution found.
This PR should fix those issues.
Should close #661 and close #633